fix: exclude build products under template from packaging #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.gitignore` was ignoring some items under template that still appeared in the packaged releases, because `template` was explicitly included in package.json, and that overrides those ignores. Adding explicit exclusions for the build products under `template` to `package.json` prevents packaging errors. I've added `template/elm-stuff` and `template/index.html` to `.gitignore` too, because those are created if `elm make src/Main.elm` is run in `template`, which seems to have been the cause. re halfzebra#275
|
Good catch! I have completely forgotten about this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.gitignorewas ignoring some items under template that still appeared in the packaged releases,because
templatewas explicitly included in package.json, and that overrides those ignores.Both the 2.0.0-rc1 and 2.0.0-rc2 releases included stray build products.
Adding explicit exclusions for the build products under
templatetopackage.jsonpreventspackaging errors.
I've added
template/elm-stuffandtemplate/index.htmlto.gitignoretoo, because thoseare created if
elm make src/Main.elmis run intemplate, which seems to have been the cause.verified the changes by using
rm *.tgz; (cd template; elm make src/Main.elm); npm pack, and inspecting the list of files packed.re #275